Improve mdox UX
#49
Merged
Improve mdox UX
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saswata Mukherjee <[email protected]>
bwplotka
approved these changes
Jun 24, 2021
pkg/mdformatter/mdformatter.go
Outdated
Comment on lines
283
to
288
| if spin != nil { | ||
| err := spin.Stop() | ||
| if err != nil { | ||
| errs.Add(err) | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| if spin != nil { | |
| err := spin.Stop() | |
| if err != nil { | |
| errs.Add(err) | |
| } | |
| } | |
| if spin != nil { | |
| errs.Add(spin.Stop()) | |
| } |
Add checks error already
pkg/mdformatter/mdformatter.go
Outdated
| f := New(ctx, opts...) | ||
| b := bytes.Buffer{} | ||
| if spin != nil { | ||
| err := spin.Start() |
Signed-off-by: Saswata Mukherjee <[email protected]>
bwplotka
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cli spinner with description for
mdox fmtcommand and adds colored diff formdox fmt --checkcommand.This does not change CI logs and only affects output when run on a terminal.
Dependencies added: glamour, yacspin, go-isatty.
Screenshots attached below.
For
mdox fmt:For diffs:
